bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: file-expand-wildcards should use `save-match-data'


From: Stefan Monnier
Subject: Re: file-expand-wildcards should use `save-match-data'
Date: 28 Mar 2002 09:47:45 -0500
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2.50

>>>>> "Richard" == Richard Stallman <address@hidden> writes:
> file-expand-wildcards is a general-purpose facility,
> and regexp matching is not its job, so I think it should
> use save-match-data.

I'm not sure what the criterion should be, and I don't really care
if file-expand-wildcards saves match-data or not, but it does
seem that file-expand-wildcards is rarely used (more specifically,
it's used twice in emacs/lisp/* plus one comment in complete.el
saying that it could now be used there) and more importantly that
few code if any would do

    match...file-expand-wildcards...use match-data

So I'd be interested to know Michael Ernst's code that broke because
of file-expand-wildcards not saving match-data.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]