browse-url-netscape's implementation and documentation are inconsistent

[Hannu Koivisto]

Greetings,

Documentation of browse-url-netscape (this may apply to other
browse-url-* functions but I haven't checked) says:

"When called non-interactively, optional second argument NEW-WINDOW
is used instead of `browse-url-new-window-flag'."

But the code does:

...
  (concat "openURL(" url
          (if
          (browse-url-maybe-new-window
               new-window)
              ",new-window")
...

and that browse-url-maybe-new-window is defined as follows:

(defmacro browse-url-maybe-new-window (arg)
  `(if (interactive-p)
       ,arg
     browse-url-new-window-flag))

It seems to me that browse-url-maybe-new-window does not consider
NEW-WINDOW parameter when the call is non-interactive but when it
is interactive, which is the opposite of what the documentation
suggests.

Emacs 21.1.

-- 
Hannu