bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Suspicious code in cmds.c


From: David Kastrup
Subject: Re: Suspicious code in cmds.c
Date: 21 Nov 2001 10:19:56 +0100
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.1

>>>>> "Christoph" == Christoph Conrad <address@hidden> writes:

 Christoph> Hello Miles,
 Christoph> you wrote:

 >> `modiff' won't change, but `MODIFF' could ...

 Christoph> ,----
 Christoph> | buffer.h: #define MODIFF (current_buffer->text->modiff)
 Christoph> `----

 Christoph> Oh yes, you're right. I Implicitly think of a constant
 Christoph> when seeing a symbol in C which is completely in capslock.

Same here.  In the interest of legibility, I'd recommend MODIFF taking
an argument of some sort, so that you'd have
MODIFF(current_buffer)
or at least
MODIFF()

Things like that are confusing.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum
Email: address@hidden



reply via email to

[Prev in Thread] Current Thread [Next in Thread]