bug-gnu-arch
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-gnu-arch] [bug #4920] tla buildcfg without default archive


From: nobody
Subject: [Bug-gnu-arch] [bug #4920] tla buildcfg without default archive
Date: Fri, 29 Aug 2003 23:45:51 -0400
User-agent: Mozilla/4.76 [en] (X11; U; FreeBSD 3.0-RELEASE i386)

=================== BUG #4920: LATEST MODIFICATIONS ==================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=4920&group_id=4899

Changes by: Tom Lord <address@hidden>
Date: Fri 08/29/2003 at 20:45 (US/Pacific)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Fixed
              Status | Open                      | Closed
       Fixed Release |                           | tla-1.1pre6, 
tla--devo--1.1--patch-146




=================== BUG #4920: FULL BUG SNAPSHOT ===================


Submitted by: tomlord                 Project: GNU arch -- a revision control 
system
Submitted on: Fri 08/22/2003 at 10:02
Category:  tla                        Severity:  5 - Major                  
Bug Group:  small feature idea        Resolution:  Fixed                    
Status:  Closed                       Release:                              
Fixed Release:  tla-1.1pre6, tla--devo--1.1--patch-146Merge Request?:  yes -- 
merge from my archive
Your Archive Name:  address@hidden Archive Location:  
http://213.200.230.54/{pubarch.v2}/address@hidden/2003
Assigned to:  tomlord                 

Summary:  tla buildcfg without default archive

Original Submission:  From: Robin Farine <address@hidden>





First, sorry for writing this directly to you but I still don't have a

publicly accessible machine where to put an archive mirror, and since

I'm attaching a patch, posting to the mailing-list sounds like a bad

idea.



Ok, here we go. Without a default archive, I'm not able to build an arch

configuration with tla buildcfg, tla version:



address@hidden/dists--devo--1.0--patch-35(emf.net/devo)



The attached patch modifies arch_build_config() to explicitely pass a -A

option to getrev using the archive name obtained from

arch_try_tree_version().



Moreover, this behavior seems more correct to me than building a config

without explicit archive names using the user's default archive, YMMV.

I'm thinking of the case where one does:



  tla get -A <archive> <revision> <dir>

  tla buildcfg <conf>



with <archive> different from one's default archive.



--rnf







--=-y53bmLWS/yA3RzGnHoaX

Content-Disposition: attachment; filename=tla-1.1-configs.diff

Content-Transfer-Encoding: quoted-printable

Content-Type: text/plain; name=tla-1.1-configs.diff; charset=ISO-8859-1



--- libarch/configs.c~  Mon Jul 14 21:46:23 2003

+++ libarch/configs.c   Wed Jul 16 16:54:20 2003

@@ -279,6 +279,7 @@

 arch_build_config (t_uchar * tree_root, t_uchar * config_name, int no_pris=

tines, int release_id)

 {

   rel_table config =3D 0;

+  t_uchar * default_archive =3D 0;

   int x;

=20

   config =3D arch_read_config (tree_root, config_name);

@@ -318,6 +319,13 @@

       lim_free (0, saved_path);

     }

=20

+  { /* get the default archive from {arch}/++default-version */

+    t_uchar * tree_version =3D arch_try_tree_version ("build-config");

+

+    default_archive =3D arch_parse_package_name (arch_ret_archive, 0, tree=

_version);

+    lim_free (0, tree_version);

+  }

+

   /* build desired trees.

    */

=20

@@ -336,8 +344,8 @@

       revspec =3D config[x][1];

=20

       status =3D (no_pristines

-                ? arch_call_cmd (arch_cmd_getrev, "getrev", "--no-pristine=

", revspec, path_to_subtree, 0)

-                : arch_call_cmd (arch_cmd_getrev, "getrev", revspec, path_=

to_subtree, 0));

+                ? arch_call_cmd (arch_cmd_getrev, "getrev", "-A", default_=

archive, "--no-pristine", revspec, path_to_subtree, 0)

+                : arch_call_cmd (arch_cmd_getrev, "getrev", "-A", default_=

archive, revspec, path_to_subtree, 0));

=20

       if (status)

         {

@@ -390,7 +398,7 @@

       lim_free (0, release_id_file);

     }

=20

-

+  lim_free (0, default_archive);

   rel_free_table (config);

 }

=20



--=-y53bmLWS/yA3RzGnHoaX--









Follow-up Comments
*******************

-------------------------------------------------------
Date: Thu 08/28/2003 at 16:52       By: rfarine
OK, changes done in patch-6 which replaces patch-1.

-------------------------------------------------------
Date: Wed 08/27/2003 at 18:52       By: tomlord
I can't merge the changes to arch_build_config.



In particular, the method of computing the default

archive is no good.  For example, if the config

is well written (uses fully qualified names) then

no default archive is needed -- but with your changes,

the command will exit with an error if no tree-version

is set.



Will you please rewrite these changes to accept a 

default version as a parameter to arch_build_config,

and pass that parameter from cmd-buildcfg.c?





-------------------------------------------------------
Date: Wed 08/27/2003 at 15:20       By: tomlord




This archive contains the changesets related to bugs #4920 and #4942:



address@hidden

  tla

    tla--rnf

      tla--rnf--1.1



        base-0

          tag of address@hidden/tla--devo--1.1--patch-106



        patch-1

          buildcfg gets its default archive from the project tree



        patch-2

          honor nested trees tagging methods & regexps during inventory



-- 

rnf








CC List
*******

CC Address                          | Comment
------------------------------------+-----------------------------
address@hidden           | I have some feedback about your changes so, hope you 
don't mind, but I added you to the CC list.



No files currently attached


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=4920&group_id=4899

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]