Re: [PATCH] global-5.9.2 - Use automake variable instead of install-data-hook in htags/Makefile.am

[Shigio YAMAGUCHI]

Hello,
Certainly, the $(localstatedir) seems not to be under the influence
of DESTDIR.  Isn't this a bug of automake?
If this is not a bug, should we write as follows?

install-data-hook:
        dir="$(DESTDIR)$(localstatedir)/gtags/sitekeys"; \
        if [ ! -d $$dir ]; then \
                $(MKDIR_P) $$dir; \
                chmod 755 $$dir; \
        fi

Your rewriting seems to have changed the operation of the
original Makefile.

> As is, htags/Makefile.am ignores DESTDIR. This patch corrects that.
> 
> 
>      jer
> --MP_/3=d9B9p4YrYGoS/5q3OQA8Z
> Content-Type: text/x-patch
> Content-Transfer-Encoding: 7bit
> Content-Disposition: attachment; filename=global-5.9.2-localstatedir.patch
> 
> --- a/htags/Makefile.am       2010-08-30 14:19:04.000000000 +0200
> +++ b/htags/Makefile.am       2010-09-01 15:19:14.000000000 +0200
> @@ -27,14 +27,8 @@
>  
>  man_MANS = htags.1
>  
> -gtagsdir = ${datadir}/gtags
> +gtagsdir = ${localstatedir}/gtags
>  gtags_DATA = global.cgi.tmpl ghtml.cgi.tmpl completion.cgi.tmpl 
> bless.sh.tmpl \
>       jscode_suggest.tmpl jscode_treeview.tmpl style.css.tmpl
>  EXTRA_DIST = $(man_MANS) $(gtags_DATA) manual.in global.cgi.tmpl.in 
> completion.cgi.tmpl.in \
>               const.h c.l cpp.l java.l php.l asm.l
> -install-data-hook:
> -     dir="$(localstatedir)/gtags/sitekeys"; \
> -     if [ ! -d $$dir ]; then \
> -             $(MKDIR_P) $$dir; \
> -             chmod 755 $$dir; \
> -     fi
--
Shigio YAMAGUCHI <address@hidden>
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3