Re: [RFC] 1 pass architecture and sorted writing.

[Hideki IWAMOTO]

Hi.
On Thu, 13 May 2010 18:44:12 +0900, Shigio YAMAGUCHI wrote...
> Index: gtags/gtags.c

> !     /*
> !      * Set flags.
> !      */
> !     flags = 0;
>       if (extractmethod)
> !             flags |= GTAGS_EXTRACTMETHOD;
>       if (debug)
> !             flags |= GTAGS_DEBUG;
> !     data.gtop[GTAGS]->flags = data.gtop[GRTAGS]->flags = flags;

When GRTAGS doesn't exist, incremental updating causes NULL pointer access. 


$ mkdir a
$ cd a
$ gtags
$ rm GRTAGS
$ touch a.c
$ gtags -i
Segmentation fault (core dumped)
$ gdb gtags core.5825
GNU gdb Red Hat Linux (6.3.0.0-1.84rh)
Copyright 2004 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "x86_64-redhat-linux-gnu"...Using host libthread_db 
library "/lib64/libthread_db.so.1".

Core was generated by `gtags -i'.
Program terminated with signal 11, Segmentation fault.
Reading symbols from /lib64/libdl.so.2...done.
Loaded symbols for /lib64/libdl.so.2
Reading symbols from /lib64/libc.so.6...done.
Loaded symbols for /lib64/libc.so.6
Reading symbols from /lib64/ld-linux-x86-64.so.2...done.
Loaded symbols for /lib64/ld-linux-x86-64.so.2
Reading symbols from /home/iwamoto/global/lib/gtags/exuberant-ctags.so...done.
Loaded symbols for /home/iwamoto/global/lib/gtags/exuberant-ctags.so
#0  0x000000000040340b in updatetags_using_builtin_parser 
(dbpath=0x7fffffafa600 "/tmp/a",
    root=0x7fffffaf95f0 "/tmp/a", deleteset=0x56e850, addlist=0x56ebc0) at 
gtags.c:1078
1078            data.gtop[GTAGS]->flags = data.gtop[GRTAGS]->flags = flags;
(gdb) p data
$1 = {gtop = {0x3, 0x570ec0, 0x0, 0x35eb233680}, fid = 0x0}
(gdb)

----
Hideki IWAMOTO  address@hidden