[bug #62363] xgettext should reset current_formatstring_parserN after each file

[Jonathan Matthew]

URL:
  <https://savannah.gnu.org/bugs/?62363>

                 Summary: xgettext should reset current_formatstring_parserN
after each file
                 Project: GNU gettext
            Submitted by: jmatthew
            Submitted on: Mon 25 Apr 2022 09:38:31 AM UTC
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

xgettext doesn't reset the current_formatstring_parserN variables after each
file, so when it's parsing a file using ITS, they will still be set to the
parser functions from the previous file that was parsed.  This can result in
strings being incorrectly tagged as format strings of various types depending
on the order of the input list.

I ran into this here: https://gitlab.gnome.org/GNOME/rhythmbox/-/issues/1937
which involves a string in a GtkBuilder file (not formatted in any way before
being displayed) that contains a % being tagged as python-format, because the
previous file in POTFILES.in was a python file.

With the attached change, the string is no longer tagged as being a format
string at all.  It doesn't cause any other change to the output .pot file.




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 25 Apr 2022 09:38:31 AM UTC  Name:
0001-xgettext-reset-current_formatstring_parserN-after-pa.patch  Size: 794B  
By: jmatthew

<http://savannah.gnu.org/bugs/download.php?file_id=53146>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?62363>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/