[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [WIP-PATCHES] Lisp (and Scheme) jump format specifier and ngettext
From: |
Miguel Ángel Arruga Vivas |
Subject: |
Re: [WIP-PATCHES] Lisp (and Scheme) jump format specifier and ngettext |
Date: |
Fri, 27 Nov 2020 14:50:57 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi Bruno,
First of all, thank you for your effort and your hints.
Bruno Haible <bruno@clisp.org> writes:
> [...]
>> The first patch is a trivial one, as it seems to me a typo, but I wanted
>> to check with you before pushing anything, as I've been out for a long
>> time. Should I push it already?
>
> This first patch is correct. The first typo is from me, the second one from
> Daiki.
I've pushed this as 6f939901b[1] to master.
> The second patch is right as well. Simply, I had never thought at explicitly
> listing plural cases in these unit tests.
> [...]
> Yes, it would be useful to add this test to the test suite.
I've joined them, because they are mostly plural case tests. With your
guidance I came to the second patch, which solves both issues. What do
you think?
Best regards,
Miguel
0001-tests-Add-Lisp-and-Scheme-plural-cases.patch
Description: 1-tests.patch
0002-format-lisp-format-scheme-Add-subset-comparison-func.patch
Description: 2-fix.patch
[1]
https://git.savannah.gnu.org/gitweb/?p=gettext.git;a=commit;h=6f939901bbcd168ab41f7f2842210b92fc6e8b6e