[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gettext] [PATCH] msgcat: Add feature to use the newest po file.

From: Bruno Haible
Subject: Re: [bug-gettext] [PATCH] msgcat: Add feature to use the newest po file.
Date: Wed, 23 Oct 2019 01:46:16 +0200
User-agent: KMail/5.1.3 (Linux/4.4.0-165-generic; KDE/5.18.0; x86_64; ; )

Hi Marketa,

This is a great contribution. Thank you!

> When concatenating po files, it is often useful to prefer strings from
> the newest file regardlees their ordering on the command line.

I agree that it makes sense, and that a command-line option is the right
way to enable this behaviour.

This is a significant addition to the gettext package; it requires a
copyright assignment to the FSF. Your employer (SuSE, I guess?) surely
already had some other employees in the same situation more than once.
Can you please start the process by which your employer makes the
copyright assignment for this contribution? Thanks.

The code looks reasonable at first sight. Just three nits:

* Please try to use GNU coding style. For example, change

   void msgdomain_sort_by_ages(msgdomain_list_ty **mdlps, size_t nfiles)


   msgdomain_sort_by_ages (msgdomain_list_ty **mdlps, size_t nfiles)




   mdlp->msgage = mktime (&tmptm);

* Please send the patch as an attachment, not inline in the mail.
  Reason: Your mailer (Thunderbird) appears to do weird things with the
  spaces and indentation. I'd like to apply the patch with "git am";
  an attachment guarantees that I can do so.

* > +#define _XOPEN_SOURCE
  This is not needed. The autoconfiguration uses the AC_USE_SYSTEM_EXTENSIONS
  macro, which arranges for _GNU_SOURCE, _XOPEN_SOURCE, etc. to be defined
  as appropriate on the target platform.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]