|
From: | Paul Eggert |
Subject: | Re: [bug-gettext] [PROPOSED] Use VLAs in C11 compilers that advertise them |
Date: | Thu, 15 Jun 2017 12:10:35 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 06/15/2017 10:45 AM, Bruno Haible wrote:
Why? Around 1992-1997 I learned the lesson that one cannot really rely on the values of __STDC_VERSION__ and the like. Too many compilers lie about it.
Although that's certainly true in general, my guess is that this particular use of __STDC_VERSION__ would be OK. It has been used that way for something similar in Gnulib's lib/vla.h, without reported problems. Admittedly vla.h is a lot less used than gettext.h is (it's used only by GNU RCS as far as I know, and it assumes modern compilers).
It's a judgment call, and your patch is a reasonable one too.
[Prev in Thread] | Current Thread | [Next in Thread] |