[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gettext] [musl] Re: AM_GNU_GETTEXT without referring internal s

From: Daiki Ueno
Subject: Re: [bug-gettext] [musl] Re: AM_GNU_GETTEXT without referring internal symbols?
Date: Fri, 27 May 2016 17:48:54 +0900
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

Rich Felker <address@hidden> writes:

> On Thu, May 26, 2016 at 09:53:49PM +0900, Masanori Ogino wrote:
>> It looks essentially good to me. You can remove the "if test
>> $gt_api_version -ge 3; then ... fi" part before where you modified too
>> if it is not used anywhere else, I guess.

I think it is still needed when AM_GNU_GETTEXT is invoked as:

  AM_GNU_GETTEXT([external], [need-formatstring-macros])

> I haven't tested it but the concept looks good to me too.

Thanks both for looking at it.  I have pushed it as:

For the record, I have tested it on the Alpine Linux image obtained from
http://www.nongnu.org/pretest/ using a test package created with:

$ cp .../gettext.m4 gnulib/m4
$ ./gnulib/gnulib-tool --create-testdir --dir=t gettext

(I had to copy libintl.h to the VM as Alpine doesn't install it)

Daiki Ueno

reply via email to

[Prev in Thread] Current Thread [Next in Thread]