[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-gettext] [PATCH] intl: Add API to get/set language precedence l
Re: [bug-gettext] [PATCH] intl: Add API to get/set language precedence list
Fri, 13 May 2016 18:58:08 +0900
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)
Bruno Haible <address@hidden> writes:
> The patch looks already nearly perfect to me. Just a few (minor) points:
Thanks for the review. I have locally fixed those except the last one:
> - Probably I would also create a new .h file for these two functions,
> because they are in layer (B) - like <locale.h> is also different from
> <libintl.h>. Yes I know gnulib has the techniques for overriding
> <libintl.h> when it needs to add two more function declarations to it;
> but nevertheless.
To do that, I think we need a good name of the public header.
Tentatively, I have chosen <i18nlang.h>, which sounds a bit ambiguous to
me. Do you have any suggestions?
Also, splitting libgnuintl.in.h is a bit of a task since it requires to
copy all the helper macros (for redefining functions) into the new file.