[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug-gettext] Modify PRI_MACROS_BROKEN macro handling

From: Steve Ellcey
Subject: [bug-gettext] Modify PRI_MACROS_BROKEN macro handling
Date: Tue, 29 Apr 2014 09:17:43 -0700
User-agent: Heirloom mailx 12.5 6/20/10

Hi,  I have been looking at fixing some GCC warnings in the build of glibc.
Part of glibc is the intl directory copied from gettext and one of the files
that is generating warnings for me is intl/loadmsgcat.c, which complains about
PRI_MACROS_BROKEN not being defined.  I could create a configure script
for the intl directory in glibc like gcc and binutils have but I would rather
not do this just to define PRI_MACROS_BROKEN if there is an easier way to
fix the problem.  I think the easier fix is to just add:


to the beginning of loadmsgcat.c (the only file that uses PRI_MACROS_BROKEN).
I suggested this to the glibc mailing group and they would like to see if this
change is something that would be considered for the official gettext version
of loadmsgcat.c first so that the glibc version of loadmsgcat.c would not have
to diverge from the official gettext version.

Is this something you would be willing to add to gettext's loadmsgcat.c?

Steve Ellcey

P.S.  The GCC warnings on '#if FOO' where FOO is not defined is new behaviour
      which is why this is coming up now.  The idea is to warn a user if they
      really meant to use '#if BOO' instead of '#if FOO'.  If you really want
      to check if something is defined or not you should use '#ifdef'.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]