[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gettext] [PATCH] x-glade: fix --extract-all option

From: Daiki Ueno
Subject: Re: [bug-gettext] [PATCH] x-glade: fix --extract-all option
Date: Tue, 13 Aug 2013 10:11:03 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Miguel Ángel Arruga Vivas <address@hidden> writes:

> Daiki Ueno <address@hidden> wrote: 
>> Given that keywords can only be specified for Glade 1 (as documented),
>> it would make more sense to just ignore it for Glade 2 and 3, IMO.
> This one ignore this flag for Glade 2 and 3 files.

Looks good, thanks.  One minor comment: it is not too intuitive that
p->extract_string means --extract-all, by looking at
start_element_glade2 and start_element_gtkbuilder.

Maybe start_element_handler could initialize p->extract_string as false,
and start_element_glade1 could check extract_all by itself?

Anyway, feel free to commit this.

Daiki Ueno

reply via email to

[Prev in Thread] Current Thread [Next in Thread]