[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gettext] [PATCH 3/3] Support GSettings schema file

From: Miguel Ángel Arruga Vivas
Subject: Re: [bug-gettext] [PATCH 3/3] Support GSettings schema file
Date: Thu, 08 Aug 2013 00:50:59 +0200

Hi Daiki,

I have to sleep so I could not build it (today), but I have a comment
for this patch:

Daiki Ueno <address@hidden> wrote: 
> diff --git a/gettext-tools/src/x-gsettings.c b/gettext-tools/src/x-gsettings.c
> new file mode 100644
> index 0000000..5b2d4d7
> --- /dev/null
> +++ b/gettext-tools/src/x-gsettings.c
> (...)
> +/* Callback called when <element> is seen.  */
> +static void
> +start_element_handler (void *userData, const char *name,
> +                       const char **attributes)
> +{
> (...)
> +  if (!p->extract_string)
> +    {

When xgettext is invoked with --extract-all option there is no
whitespace normalization neither context extraction. IMHO this is a bug,
also in Glade support. A solution could be erase this condition and
change next line:

> +      bool has_translatable = false;

with this one:

> +      bool has_translatable = p->extract_string;

This way every string is extracted when extract_all is true but
retaining msgctxt.

As soon as I have some time I could send a fix for this issue in
Glade2/3. I have to update examples too... Sorry for my delay. :(

Happy Hacking! :)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]