[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-gettext] [PATCH] gettext-runtime: use @SHELL@ for the SHELL var
Re: [bug-gettext] [PATCH] gettext-runtime: use @SHELL@ for the SHELL variable definition
Tue, 28 May 2013 20:04:44 +0200
Dear Mike Rosset,
On Tue, 28 May 2013 10:36:16 -0700, Mike Rosset wrote:
> Thanks for this, I created a patch for awhile back for
> The problem only occurs under certain corner cases. For example if
> /bin/sh is not symlinked to bash in the case of ubuntu where they use
> dash and only while boot strapping autoconf submodules.
Correct. Until I did some other (unrelated) changes to gettext's
configure.ac, I wasn't seeing any problem. However, the problem becomes
clear once you autoreconf gettext, and you run on a system where sh is
a POSIX shell that doesn't understand the += bashim that libtool is
> But due to the
> complexity of autotools I was worried it might break something else.
All other Makefile.in are doing this, and the SHELL variable gets
properly expanded to the correct value, from my testing. So it should
> While I was bisecting from my impression Makfile.in was hard copied
> over and this issue has gone unnoticed since that time and more then
> likely this patch is fine. Either way +1 if this can get applied.
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.