[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Tue, 16 Apr 2013 23:50:35 +0200
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5
Daiki Ueno wrote:
> The attached is a revised patch based on yours found on github:
> * remove support for '\a' and '\U', which are not supported by
> * fix multiline comment handling (/* ... */)
I've to look into that, strange we didn't step onto this in our
> * make newline acceptable in regular expression literals
Again good catch. I'll extend the test suit with this one and
the multiline comments above.
> * remove INTERPRET_ANSIC and INTERPRET_UNICODE option from
Too much copy & paste by me :-/
> * treat 'else' as well as 'return' for div vs. regex check
You've already added this to the test suite I see.
> * add Unicode escape test
Yes, this must not be missing from the test suite.
> * update document and FILES
Well they should be identical: The rebase was an attempt to make it
easier to merge during the long time of silence.
> Also, I still don't get the idea of this change:
Hmm, I'm curious too, the commit didn't highlight _why_ it needs
to check for equality. Currently I'm to tired to grasp this...
Thanks for your intense review on this patch. What's still left
to be done before it can be integrated? I'll run it over our code
base to check if there any problems and bugs left.
Description: OpenPGP digital signature