[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gettext] JavaScript support

From: Andreas Stricker
Subject: Re: [bug-gettext] JavaScript support
Date: Tue, 16 Apr 2013 23:50:35 +0200
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5

Daiki Ueno wrote:

> The attached is a revised patch based on yours found on github:
> https://github.com/AndyStricker/gettext-javascript

Thanks for sanitizing my gettext-javascript branch into a single patch.

> * remove support for '\a' and '\U', which are not supported by
>   JavaScript

Good catch.

> * fix multiline comment handling (/* ... */)

I've to look into that, strange we didn't step onto this in our
Javascript codebase.

> * make newline acceptable in regular expression literals

Again good catch. I'll extend the test suit with this one and
the multiline comments above.

> * make string concatenation code in x_javascript_lex more readable
> * remove INTERPRET_ANSIC and INTERPRET_UNICODE option from
>   phase7_getuc, since raw strings are not supported by JavaScript

Too much copy & paste by me :-/

> * treat 'else' as well as 'return' for div vs. regex check

You've already added this to the test suite I see.

> * add Unicode escape test

Yes, this must not be missing from the test suite.

> * update document and FILES


> By the way, which is the latest development branch: javascript or
> js-rebased?

Well they should be identical: The rebase was an attempt to make it
easier to merge during the long time of silence.

> Also, I still don't get the idea of this change:
> https://github.com/AndyStricker/gettext-javascript/commit/44008a5ba866ba184f667853672846f50e27f844

Hmm, I'm curious too, the commit didn't highlight _why_ it needs
to check for equality. Currently I'm to tired to grasp this...

Thanks for your intense review on this patch. What's still left
to be done before it can be integrated? I'll run it over our code
base to check if there any problems and bugs left.

Regards, Andy

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]