[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gettext] gettext-lua

From: Ľubomír Remák
Subject: Re: [bug-gettext] gettext-lua
Date: Thu, 11 Apr 2013 20:47:06 +0200


> I've squashed those commits into one, and pushed to maint branch (which
> will be merged to master soon).

Awesome! Thank you.

> Since I modified the code a bit, it would be great if you could check
> the changes.  I did:
> * reformat comments according to GNU Coding Standards[1]
> * mention Lua in xgettext --help
Oops, I thought I had already done that, but now I can see I missed a
few places.

> * list lua files in FILES
Shouldn't format-lua.c be included too?

> * adjust coding style of copied code to other extractors
> * add '\ddd' string to test (maybe good to support '\xXX' in Lua 5.2, btw)
That's a good idea. I've just noticed Lua 5.2 adds \z too. I'll take a
look at this.

> * untabify

> By the way, is this the right gettext extension needed at run time?
> https://github.com/LubomirR/luagettext
> If so, it might be good to mention it somewhere in docs.

Yes, this is the right extension.

Best regards,
Ľubomír Remák

reply via email to

[Prev in Thread] Current Thread [Next in Thread]