[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gettext] [Patch 2/2] Libasprintf bug fixes

From: Miguel Ángel
Subject: Re: [bug-gettext] [Patch 2/2] Libasprintf bug fixes
Date: Mon, 04 Mar 2013 10:35:16 +0100

Daiki Ueno <address@hidden>: 
> Miguel Ángel <address@hidden> writes:
> Couldn't find the patch, but assuming it is:
> "Do not define __attribute__ in header files."
> <https://github.com/644rosen/gettext_gtkbuilder_support/commit/22e0ea4415f269f1f30014cfa34e2bd17b4a6e1b>

Sorry, I did not attached it, but It is the right commit.

> Can't it be fixed if we just port this from gnulib?
> commit f6a5a124d0cb326acd4dfa9ce3276baa26734b16
> Author: Bruno Haible <address@hidden>
> Date:   Sun Feb 13 23:21:20 2011 +0100
>     Don't interfere with a program's definition of __attribute__.
> <http://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=f6a5a124d0cb326acd4dfa9ce3276baa26734b16>

I chose to not define a new macro (although It was my first patch) to
not add other symbol, but It can be reverted to the old patch, whose
changes are almost a port of that commit without any knowledge about
it. :)

Thank you for the reviewing.
Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]