[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gettext] [PATCH] Determine Woe32 C symbol prefix at configure t

From: B. Scott Michel
Subject: Re: [bug-gettext] [PATCH] Determine Woe32 C symbol prefix at configure time.
Date: Thu, 27 Dec 2012 09:40:37 -0800
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Thunderbird/17.0

On 12/27/2012 1:28 AM, Daiki Ueno wrote:
> See <http://savannah.gnu.org/bugs/?29946>.
> Because of my poor understanding of Woe32 platforms, the mingw w64
> patch[1] applied to 0.18.2 was too ad-hoc, as it hard-codes C prefix
> as "__imp_" when _WIN64 is defined.
> On the above issue, Evgeny kindly explaind the background and suggested
> to detect the prefix at configure time.  Here is the proposed patch.
> Footnotes: 
> [1]  http://lists.gnu.org/archive/html/bug-gettext/2012-12/msg00049.html
The better fix is to __not__ manually mangle the symbols with the
"magic" IMP macro. Instead, the library should support symbol
visibility, such as dllexport()/dllimport() for WinXX platforms and
_attribute_ ((visibility("hidden"))) for Linux ELF. The "brain damage"
for WinXX is that while building the library, dllexport() has to be in
force, whereas during linking, dllimport() has to be in force. Similarly
for Linux.

Not hard to do, but my patch for this style of code hits a lot of files.
I'd have to do a bit of work to wrangle the patch into shape.

Q: Should I post the patch as an addendum to the existing Savannah bug
report or post to the list?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]