[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gettext] gettext maintenance

From: Bruno Haible
Subject: Re: [bug-gettext] gettext maintenance
Date: Sat, 08 Dec 2012 04:00:28 +0100
User-agent: KMail/4.7.4 (Linux/3.1.10-1.9-desktop; KDE/4.7.4; x86_64; ; )

Daiki Ueno wrote:
> > FAIL: test-u8-possible-linebreaks
> > FAIL: test-ulc-width-linebreaks
> > FAIL: test-u8-mbtouc
> > FAIL: test-u8-mbtouc-unsafe
> > FAIL: uniwidth/test-uc_width2.sh
> >
> > These failures are consequences of changes in libunistring behaviour.
> > What happens is that gettext embeds the test suite from the newest
> > (unreleased) libunistring, but the LDFLAGS make it link to the
> > installed libunistring. Any change in behaviour thus comes out as a
> > test failure.
> Thanks for the hint.  I'm thinking of skipping those tests for now, like
> the attached patch.

Yes this looks good; kudos that you found this simple and clean approach.

Just a detail of a comment:

+    # Ignore tests known to be fail with the released libunistring.
+      hash-tests

The reason why hash-tests is ignored is:
1) 'hash-tests' comes from gnulib and is unrelated to the module 'hash'
   which comes from gettext/gnulib-local/
2) It tests functions that are not exported from libgettextlib and
   libgettextpo on platforms where the autoconf macros in visibility.m4
   have an effect. visibility.m4 ensures that programs can't accidentally
   use "private" symbols of libgettextlib and libgettextpo; the downside
   is that test programs can't be linked.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]