gdb-5.3 -- some minor build problems + 3 patches

[Peter Breitenlohner]

Hi,

attached please find 3 patches for gdb-5.3 which address several minor build
problems. Each patch starts whith comment which I repeat here:

1. patch-01-gdbserver-config
        gdbreplay.c uses `#ifdef HAVE_STDLIB_H', but configure and config.h
        don't define this. Consequently <stdlib.h> was not included,
        resulting in an "implicit declaration of `atoi'" warning.

2. patch-02-gdbserver-ldflags
        LDFLAGS were not propagated from gdb to gdb/gdbserver.
        Consequently "make LDFLAGS=-s" did produced unstripped gdbreplay and
        gdbserver binaries.

        All this wouldn't be needed, if the gdb distribution were to support
        "make install-strip" as most modern packages do. Unfortunately this
        feature has not (yet?) found its way into the cygnus type source
        trees (nor has DESTDIR support).

3. patch-03-gdb-readline
        It really is a shame that gdb still uses the outdated readline-4.1
        and (sort of) insists on using the readline distributed with gdb.
        There really ought to be a configure option
        '--with-installed-readline' or similar (in particular in case where
        the installed library is a shared one).

        All that can, actually, be achieved by minor changes in
        gdb/Makefile, and I don't terribly care wether or not the realine
        distibuted with gdb is built or not -- as long as it is not used.

        There are, however, several incompatibilities between   readline-4.1
        and readline-4.[23].

        The aim of this patch is to take care of these incompatibilities.
        With these changes gdb can be compiled with either the distributed
        readline-4.1 or an installed readline-4.[123] via said minor changes
        in gdb/Makefile.

        Given this patch, I would like to strongly suggest that future
        versions of gdb be distributed with readline-4.3, and have a
        configure '--with-installed-readline' option.

============================

4. A final remark/question. Compiling libiberty for ix86-linux-gnu (with
gcc-2.95.3) produces lots of warnings, a few from gdb-5.3/libiberty/regex.c
but mostly from gdb-5.3/libiberty/md5. They are almost exclusively:
        warning: integer constant is unsigned in ANSI C, signed with 
-traditional

Is there really no decent way to avoid all these warnings?

regards
Peter Breitenlohner <address@hidden>

patch-01-gdbserver-config
Description: Text document

patch-02-gdbserver-ldflags
Description: Text document

patch-03-gdb-readline
Description: Text document