Re: [bug-gawk] [PATCH] Add missing include files in autoconf tests, for C99 compilers

[arnold]

Hi.

Thank you for these changes. I have them in a local branch.

Per earlier private email, the FSF wants you to sign individual paperwork
and then I can merge them.  Perhaps you can arrange to just sign paperwork
one time to cover all GNU software; please check with them.

Please also ack this note and keep me in the loop on the paperwork.

Thanks!

Arnold

Florian Weimer <address@hidden> wrote:

> ---
>  ChangeLog      | 7 +++++++
>  configure      | 4 ++++
>  configure.ac   | 2 ++
>  m4/ChangeLog   | 5 +++++
>  m4/readline.m4 | 2 ++
>  5 files changed, 20 insertions(+)
>
> diff --git a/ChangeLog b/ChangeLog
> index 081f07db..92a26073 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,10 @@
> +2019-09-10  Florian Weimer  <address@hidden>
> +
> +     * configure.ac (PRINTF_HAS_F_FORMAT): Include <string.h> for
> +     strcmp.
> +     (PRINTF_HAS_A_FORMAT): Likewise.
> +     * configure: Regenerate.
> +
>  2019-09-01         Arnold D. Robbins     <address@hidden>
>  
>       * profile.c (pp_list, pp_concat): Fix use-after-free errors
> diff --git a/configure b/configure
> index ee0bbbfc..8d5d2d21 100755
> --- a/configure
> +++ b/configure
> @@ -10169,6 +10169,7 @@ else
>  
>  
>  #include <stdio.h>
> +#include <string.h>
>  
>  int main()
>  {
> @@ -10211,6 +10212,7 @@ else
>  
>  
>  #include <stdio.h>
> +#include <string.h>
>  
>  int main()
>  {
> @@ -10455,6 +10457,8 @@ else
>    cat confdefs.h - <<_ACEOF >conftest.$ac_ext
>  /* end confdefs.h.  */
>  #include <stdio.h>
> +#include <fcntl.h>
> +#include <unistd.h>
>  #include <readline/readline.h>
>  #include <readline/history.h>
>  
> diff --git a/configure.ac b/configure.ac
> index 7c01f48d..f353cea3 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -361,6 +361,7 @@ AC_MSG_CHECKING([for printf %F format])
>  AC_RUN_IFELSE([
>  AC_LANG_SOURCE([
>  #include <stdio.h>
> +#include <string.h>
>  
>  int main()
>  {
> @@ -389,6 +390,7 @@ AC_MSG_CHECKING([for printf %a format])
>  AC_RUN_IFELSE([
>  AC_LANG_SOURCE([
>  #include <stdio.h>
> +#include <string.h>
>  
>  int main()
>  {
> diff --git a/m4/ChangeLog b/m4/ChangeLog
> index 6df93c56..a4e8450c 100644
> --- a/m4/ChangeLog
> +++ b/m4/ChangeLog
> @@ -1,3 +1,8 @@
> +2019-09-10  Florian Weimer  <address@hidden>
> +
> +     * readline.m4 (GAWK_CHECK_READLINE): Include <fcntl.h>, <unistd.h>
> +     for close, open, dup.
> +
>  2019-06-18         Arnold D. Robbins     <address@hidden>
>  
>       * 5.0.1: Release tar ball made.
> diff --git a/m4/readline.m4 b/m4/readline.m4
> index 5c0bb1ea..12f389bf 100644
> --- a/m4/readline.m4
> +++ b/m4/readline.m4
> @@ -39,6 +39,8 @@ AC_DEFUN([GAWK_CHECK_READLINE],
>       AC_TRY_RUN(
>  dnl source program:
>  AC_LANG_SOURCE([[#include <stdio.h>
> +#include <fcntl.h>
> +#include <unistd.h>
>  #include <readline/readline.h>
>  #include <readline/history.h>
>  
> -- 
> 2.21.0
>