bug-gawk
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gawk] gawk with dates before 1970


From: Andrew J. Schorr
Subject: Re: [bug-gawk] gawk with dates before 1970
Date: Thu, 16 Apr 2015 12:56:55 -0400
User-agent: Mutt/1.5.23 (2014-03-12)

Hi,

On Thu, Apr 16, 2015 at 01:17:16PM +0300, Aharon Robbins wrote:
> > There are 2 macros in Gnulib's intprops.h, called TYPE_MINIMUM and
> > TYPE_MAXIMUM, which is all that we need.  Never mind their insanely
> > complex definitions, we just need to steal them, put them on some Gawk
> > header, and then use them.
> 
> It turns out I have them already in builtin.c. I just added some
> checks against them and pushed. I think this whole issue can be closed
> now.

Thanks.  I hate to beat a dead horse, but why is it a fatal error
when the timestamp argument is out of time_t range, as opposed to
simply returning an empty string when gmtime/localtime fails?
Shouldn't we handle these consistently?  My personal preference might be
to return "" in both cases along with a warning message.

Regards,
Andy



reply via email to

[Prev in Thread] Current Thread [Next in Thread]