[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-freedink] Re: freedink for mac os x - follow ups

From: Sylvain Beucler
Subject: [Bug-freedink] Re: freedink for mac os x - follow ups
Date: Sun, 15 Mar 2009 09:36:49 +0100
User-agent: Mutt/1.5.18 (2008-05-17)


>> - I don't think changing paths is a good idea:
>> https://trac.macports.org/browser/trunk/dports/games/freedink/files/patch-src-paths.c.diff?rev=48065
>>   FreeDink needs to run in a _consistent_ way across platforms, so
>>   patching the default paths is asking for troubles. Did you try using
>>   ./configure --prefix=/opt/local instead?
> macports *must* install in /opt. The problem is that freedink-data can't  
> be expanded in /usr.... because this violates macports
> *but* freedink engine searches data only in those paths in paths.c.  
> There is no problem where freedink-engine is installed, but
> freedink-data *must* be under /opt. How can i solve this issue?

I see the problem.

This line should do the job:
    default3 = br_build_path(datadir, "dink");

FreeDink proceeds this way:
- it try to detect where it's installed (e.g. /opt/local/bin/freedink)
- it then builds a prefix (e.g. /opt/local)
- if detection failed it uses the built-in prefix (from
  ./configure --prefix=...)
- when the prefix is determined, it then search for $prefix/share/dink,
  which is where you installed freedink-data

So if you install FreeDink in /opt/local/bin/freedink, it should look
in /opt/local/share/dink already :) (this is called relocatable

If you use './configure --prefix=/opt/local', then it will also look
there first.  You probably do that already so that 'make install'
copies files in '/opt/local'.

If for some reason this fails, there's probably something to fix in
FreeDink. In which case, will you send me the beginning of the
terminal output? There should be a line saying "Hi, I'm
/opt/local/bin/freedink" followed by the lookup paths.

>> More generally, if you find a problem in FreeDink, feel free to
>> discuss it and possibly send patches. I think it's safer for end users
>> when they all use the same versions, so they can freely move from one
>> environment to another, plus if improvements are shared, they'll apply
>> to too :)
> I did not send you that patch because it is a patch applied only to  
> macport-driven freedink installations.
> I'm sorry ;)

I think that a portable program needs to run without patch as much as
possible.  I'm glad to add the patches directly in FreeDink, so we can
discuss them, and they can benefit everybody :)

Currently I'm working on a port for playstation portable, and I found
that 90% of the needed changes could be written as an improvement of
the game engine, plus it would benefit at least another porter who
works on xbox.

Btw, thanks for letting me know about your progress :)

Also, I've updated freedink.org with your instructions. Are there
other webpages about the macport that I can point to?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]