[bug #51841] find buffer-overflow with -printf '%T+'

[Andreas Metzler]

Follow-up Comment #5, bug #51841 (project findutils):

On 2017-09-06 Bernhard Voelker <address@hidden> wrote:
> It seems they fail here:
> -l1 1990-06-22+14:00:00.0000000000 646056000.0000000000 [...]
> +l1 1990-06-22+12:00:00.0000000000 646056000.0000000000 [...]

> The expected output for '%T+' depends on the local timezone.
> As the next part '%T@' is output in GMT, maybe it would work
> if you set TZ to the same?

Hello,

actually I had been wondering why the tests worked since my TZ is !=  UTC and
assumed the testsuite already used a sanitized TZ. Well I realized that the
chroot was using TZ=UTC. :-(

Anyway, yes that is exactly the fix that needs to be done.
env TZ=UTC make check
would work.

However I am failing at changing find's environment in the testsuite. Any
idea?

What fails:
1) adding this to the top of find/testsuite/find.gnu/printf.exp
global env;
set env{TZ} "UTC"

2) modifying find/testsuite/config/unix.exp
--- a/find/testsuite/config/unix.exp
+++ b/find/testsuite/config/unix.exp
@@ -27,6 +27,7 @@ global FTSFIND
 verbose "base_dir is $base_dir" 2
 global env;
 set env(GNU_FINDUTILS_FD_LEAK_CHECK) "1"
+set env{TZ} "UTC"

cu Andreas



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51841>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/