|
| From: | Paul Eggert |
| Subject: | Re: a minor bug |
| Date: | Wed, 23 Dec 2015 15:13:45 -0800 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
James Youngman wrote:
+static FILE* fopen_cloexec_for_read_only (const char *file_name) {
+ int fd = open_cloexec (file_name, O_RDONLY);
+ return (fd < 0) ? NULL : fdopen (fd, "r");
+}
This should close fd if fdopen fails, no? Also, the indentation should be fixed to be GNU-like.
| [Prev in Thread] | Current Thread | [Next in Thread] |