[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fts: introduce FTS_NOATIME

From: Paul Eggert
Subject: Re: [PATCH] fts: introduce FTS_NOATIME
Date: Thu, 07 Jul 2011 14:02:16 -0700
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110428 Fedora/3.1.10-1.fc14 Thunderbird/3.1.10

On 07/07/11 10:41, Eric Blake wrote:
> This gives clients the option to try a non-invasive traversal,

Thanks for doing that; a couple of minor comments:

> -            int fd = open (".", O_SEARCH);
> +            int fd = open (".",
> +                           O_SEARCH | (ISSET (FTS_NOATIME) ? O_NOATIME : 0));

Shouldn't this use diropen rather than open?  Then you don't need
to worry about checking the flag here.  (This comment applies to
the existing code, too.)

> +          int parent_fd = openat (cwd_fd, "..", O_SEARCH | O_NOATIME);

This uses O_NOATIME even when the user hasn't asked for it.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]