[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/19] configure.ac: Quote the first argument to AC_DEFINE.
From: |
Eric Blake |
Subject: |
Re: [PATCH 07/19] configure.ac: Quote the first argument to AC_DEFINE. |
Date: |
Fri, 02 Apr 2010 16:57:34 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b1 Thunderbird/3.0.4 |
On 04/02/2010 04:47 PM, James Youngman wrote:
>
> + Move safe_atoi out into a separate module.
> + * find/parser.c: Include "safe-atoi.h". Remove the body of safe_atoi.
> + (parse_group): pass options.err_quoting_style to safe_atoi.
> + (insert_depthspec): Likewise.
> + (parse_user): Likewise.
> + * lib/safe-atoi.h: New file.
> + * lib/safe-atoi.c: New file. Add parameter for quoting style (to
> + avoid an external reference to the "options"struct).
> + * lib/Makefile.am (libfind_a_SOURCES): Add safe-atoi.c and
> + safe-atoi.h.
> +
> +++ b/configure.ac
> @@ -18,7 +18,7 @@ FIND_WITH_FTS
>
> AC_ARG_ENABLE(id-cache,
> [ --enable-id-cache cache all UIDs & GIDs; avoid if using NIS or
> Hesiod],
> - AC_DEFINE(CACHE_IDS, 1, [Define if you want find -nouser and -nogroup to
> make tables of
> + AC_DEFINE([CACHE_IDS], 1, [Define if you want find -nouser and -nogroup to
> make tables of
The subject line was right, but the ChangeLog portion looks like it came
from another patch.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [PATCH 06/19] Avoid false positives for the sc_prohibit_test_minus_ao syntax check., (continued)
- [PATCH 06/19] Avoid false positives for the sc_prohibit_test_minus_ao syntax check., James Youngman, 2010/04/02
- [PATCH 04/19] Fix some compilation unused-result and missing-declaration warnings., James Youngman, 2010/04/02
- [PATCH 08/19] Move safe_atoi out into a separate module., James Youngman, 2010/04/02
- [PATCH 09/19] Remove some obsolete source files from POTFILES.in, James Youngman, 2010/04/02
- [PATCH 11/19] Avoid sscanf. Avoid false positives for sc_prohibit_atoi_atof., James Youngman, 2010/04/02
- [PATCH 10/19] Remove files which exist but have no translated messages., James Youngman, 2010/04/02
- [PATCH 07/19] configure.ac: Quote the first argument to AC_DEFINE., James Youngman, 2010/04/02
- Re: [PATCH 07/19] configure.ac: Quote the first argument to AC_DEFINE.,
Eric Blake <=
- [PATCH 13/19] Enable syntax checker sc_the_the, detecting doubled 'the'., James Youngman, 2010/04/02
- [PATCH 12/19] sc_prohibit_strcmp gives false positives when neither argument is a constant, so skip that check, James Youngman, 2010/04/02
- [PATCH 14/19] Avoid sc_prohibit_stat_st_blocks check, since it is broken., James Youngman, 2010/04/02
- [PATCH 15/19] Avoid using magic numbers as exit statuses., James Youngman, 2010/04/02
- [PATCH 16/19] Use set_program_name() to remember the programs' names., James Youngman, 2010/04/02
- [PATCH 17/19] Don't include quote.h/quotearg.h where it is not used., James Youngman, 2010/04/02
- [PATCH 18/19] cfg.mk: simplify variables, James Youngman, 2010/04/02
- [PATCH 19/19] Check for accidental modifications to the wrong section of the NEWS file., James Youngman, 2010/04/02