Re: [PATCH] avoid build failure when compiling with -DGNULIB_PORTCHECK

[James Youngman]

On Fri, Dec 26, 2008 at 5:20 PM, Jim Meyering <address@hidden> wrote:
> +
> +      /* Avoid failure when compiling with -DGNULIB_PORTCHECK. */
> +#undef ctime

To be honest, I am not comfortable with this fix, mostly because I
would prefer to avoid interfering with a global symbol; if a later
porting change needed to #define ctime, then this change would defeat
it.


> +
>       fprintf (stderr, "%ju %s",
>               (uintmax_t) our_pred->args.reftime.ts.tv_sec,
>               ctime (&t));

This is just a debug message; perhaps changing the output formatting
to use strftime would be a better solution.

James.