Re: findutils-4.2.15 -- "make check" fails + request + 2 patches

[James Youngman]

On Mon, Jan 31, 2005 at 02:26:36PM +0100, Peter Breitenlohner wrote:

> 1. "make check" fails. The attached patch "path-02-check" should fix this
> problem.
> 
>       It seems that files at the same level are always sorted
>       alphabetically by find.

This is not a property of "find" - and in fact does not happen on my
system (Debian GNU/Linux).  This must be a behaviour of readdir() on
your system.

Anyway, it is valid for systems to return directory entries in any
order, and the fidutils test suite should not depend on any particular
order in for it to have a successful test run.  Therefore I have
changed the test suite so that the otuput of "find" is now sorted
before it is compared against the ".xo" file.

These changes have been checked into the CVS code and will be
available in the next release.  If you want to try them out sooner,
please get the CVS code - see
http://savannah.gnu.org/cvs/?group=findutils.

> 2. I'd like to ask for an enhancement in updatedb as per the attached patch
> "path-01-pathfilter".

This is a good idea.  However the change I actually plan to make
(eventually) is one that will properly fix the problem outlined by
Bruno Haible at
http://savannah.gnu.org/bugs/?func=detailitem&item_id=8599.  That
really needs a more general solution than this one, since any given
NFS server may have several clients, each of which mount the
filesystem in a different location.

Therefore, although your idea is a good one, I'm not going to apply
your patch.  However, if you have some ideas as to how to solve the
problem in the more general case, I'd encourage you to work with Bruno
to find a solution.  I've copied Bruno on this email.


Regards and thanks, 
James.