[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: locate.c (visit_exists): Use printname, not testname.
From: |
Bas van Gompel |
Subject: |
Re: locate.c (visit_exists): Use printname, not testname. |
Date: |
Mon, 3 Jan 2005 02:44:35 +0100 (MET) |
User-agent: |
slrn/0.9.8.1 (Win32) Hamster/2.0.6.0 Korrnews/4.2 |
Op Sun, 2 Jan 2005 23:53:34 +0000 schreef James Youngman
in <address@hidden>:
: On Sun, Jan 02, 2005 at 10:37:35PM +0100, Bas van Gompel wrote:
: > Hi,
: >
: > Another little patch, this time to make the combination of -e with
: > -i and/or --basename behave more like (I) expected.
:
: You're right - thanks; I've applied this. Really the problem was that
: those function arguments are not ideally named. I have added a
: comment to the code which explains the problem too.
You --being the maintainer-- could of course change the names to
something more sensible...
...A struct could be used to reduce the number of pushes/pops.
(This would add a level of indirection to references though...)
``procdata->raw_string'' and ``procdata->munged_string''?
OTOH, one could use global variables and dispense with parameters /and/
indirect references. (If you aren't planning on ever having a multi-
threaded locate, this might speed things up some more...)
L8r, HAN2005,
Buzz.
BTW: Why don't you allow ``locate -b string''?
BTW2: Why don't you document ``locate -S'' (with an ``itemx'')?
BTW3: sed -i -e 's/ filly/ fully/' doc/find.texi
BTW4: Although I like the source comment (about adding visit_exists
late), I don;t think I deserve the credit for this. The info/man text
about --existing seem (to me) to express an intent to do it this way.
BTW5: Could you mail me (PM OK) some info about GNU copyright-
assignments/disclaimers? I have more mods, not all as small as the last
ones. (Sorry to bother you about this, but searching the web seems to
indicate you _are_ the person to ask.)
--
) | | ---/ ---/ Yes, this | This message consists of true | I do not
-- | | / / really is | and false bits entirely. | mail for
) | | / / a 72 by 4 +-------------------------------+ any1 but
-- \--| /--- /--- .sigfile. | |perl -pe "s.u(z)\1.as." | me. 4^re