Re: [bug-diffutils] Bug#648411: diffutils: description of -I option is wrong (fwd)

[Eric Blake]

On 03/04/2012 02:24 PM, Paul Eggert wrote:
> Thanks, I applied this to the diffutils master branch:
> 
>>From a96c4da999cc1704146ea0eb7ba86c6dbbea1cad Mon Sep 17 00:00:00 2001
> From: Paul Eggert <address@hidden>
> Date: Sun, 4 Mar 2012 13:19:55 -0800
> Subject: [PATCH] doc: explain -I RE better in --help output
> 
> * src/diff.c, src/sdiff.c (option_help_msgid): For -I RE,
> change "whose lines all match" to "all whose lines match" to avoid
> unintended interpretation.  Reported by Danijel Tasov in
> <http://bugs.debian.org/648411>.
> ---
>  src/diff.c  |    2 +-
>  src/sdiff.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/diff.c b/src/diff.c
> index 200112b..85950fa 100644
> --- a/src/diff.c
> +++ b/src/diff.c
> @@ -894,7 +894,7 @@ static char const * const option_help_msgid[] = {
>    N_("-b, --ignore-space-change       ignore changes in the amount of white 
> space"),
>    N_("-w, --ignore-all-space          ignore all white space"),
>    N_("-B, --ignore-blank-lines        ignore changes whose lines are all 
> blank"),
> -  N_("-I, --ignore-matching-lines=RE  ignore changes whose lines all match 
> RE"),
> +  N_("-I, --ignore-matching-lines=RE  ignore changes all whose lines match 
> RE"),

That still reads awkwardly to me.  Would this be any better:

ignore changes where all lines match RE

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature