[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-dejagnu] BUG: improper format string construction in framework.
From: |
Andreas Schwab |
Subject: |
Re: [Bug-dejagnu] BUG: improper format string construction in framework.exp |
Date: |
Mon, 29 Oct 2018 10:03:11 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
On Okt 28 2018, Jacob Bachmeyer <address@hidden> wrote:
> diff --git a/lib/framework.exp b/lib/framework.exp
> index 6cb93c5..50ac757 100644
> --- a/lib/framework.exp
> +++ b/lib/framework.exp
> @@ -800,7 +800,7 @@ proc record_test { type message args } {
>
> global multipass_name
> if { $multipass_name != "" } {
> - set message [format "$type: %s: $message" "$multipass_name"]
> + set message [format "%s: %s: %s" "$type" "$multipass_name" "$message"]
What's the point of using format in the first place?
set message "$type: $multipass_name: $message"
Andreas.
--
Andreas Schwab, SUSE Labs, address@hidden
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
Re: [Bug-dejagnu] BUG: improper format string construction in framework.exp (follow-up), Jacob Bachmeyer, 2018/10/28