[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-ddrescue] [PATCH 5/7] [clang-tidy] Don't use else after a retur

From: Paul Daniels
Subject: Re: [Bug-ddrescue] [PATCH 5/7] [clang-tidy] Don't use else after a return statement
Date: Wed, 16 Oct 2019 07:59:19 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 16/10/19 5:58 am, Antonio Diaz Diaz wrote:
Rosen Penev wrote:
Found with readability-else-after-return

I probably won't apply any of these. I'm somewhat annoyed by the "code of conduct" that some compilers try to impose on developers. In particular I find the folowing much more readable with the else than without. Moreover, g++ could complain about "misleading indentation" in the second case.

-      { if( domain < sb ) break; else continue; }
+      { if( domain < sb ) break; continue; }

    I concur.  The obsession over the code pedantry in the compiler seems to have simply gone just too far these days; readability is definitely going backwards which in turn makes for more potential bugs.



Bug-ddrescue mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]