[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Failure of expensive test "datamash-valgrind.sh" for git HEAD

From: Tim Rice
Subject: Re: Failure of expensive test "datamash-valgrind.sh" for git HEAD
Date: Wed, 1 Jun 2022 21:58:36 +0000

Hey Erik,

Yeah, I was looking at this too. I want to make sure all expensive
tests pass before opening 1.8 up for testing. This is not the only
expensive test that fails for me, btw. The one for doing i/o on a full
filesystem is also a bit wonky.

I tried the filesystem image based tests only once.  They succeeded
for me.  Only the valgrind test failed.

For me, there is a problem when using the mkfs.ext3 on such a small image:

$ mkfs.ext3 -v -b 1024 tiny_disk.img
mke2fs 1.46.5 (30-Dec-2021)
fs_types for mke2fs.conf resolution: 'ext3', 'floppy'

Filesystem too small for a journal
Discarding device blocks: done
Discard succeeded and will return 0s - skipping inode table wipe
Filesystem label=
OS type: Linux
Block size=1024 (log=0)
Fragment size=1024 (log=0)
Stride=0 blocks, Stripe width=0 blocks
8 inodes, 64 blocks
3 blocks (4.69%) reserved for the super user
First data block=1
1 block group
8192 blocks per group, 8192 fragments per group
8 inodes per group

Allocating group tables: done
Writing inode tables: done
ext2fs_mkdir: Could not allocate inode in ext2 filesystem while creating 

I just now figured out it works okay if I add `-T small` to mkfs.ext3. I'll 
send that change up.

I am not sure about the "badfs" test, because it also tests the kernel's
filesystem implementation by randomly corrupting a filesystem image.
Perhaps this could be seperated into its own test file with another
guard in addition to "expensive"?

I don't see it as a high priority, but if you want to implement such a change, 
feel free.

~ Tim

reply via email to

[Prev in Thread] Current Thread [Next in Thread]