[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fixed incomplete and incorrect treatment of comments and tra
From: |
Erik Auerswald |
Subject: |
Re: [PATCH] Fixed incomplete and incorrect treatment of comments and trailing whitespace |
Date: |
Fri, 20 May 2022 08:32:42 +0200 |
Hello Dima,
On Thu, May 19, 2022 at 08:28:47PM -0700, Dima Kogan wrote:
> [...]
> - Also support trailing comments:
>
>
> https://github.com/dkogan/datamash/commit/ae9a6965219e441ba883a3b5e283d49602b799a0
>From a quick glance at the code diff in the link, this seems to allow
comments inside a field, e.g., with datamash -H -C -t',' and the
following input:
# the next line is the header line
one,two,three
# the following line is the data line
1,2#this is the 2nd field,3
in the data line the string "#this is the 2nd field" would be skipped,
and the data line would have three fields with values 1, 2, and 3.
Is that correct (I did not test it)? Is that the intended functionality?
Would you like to extend the documentation with a description of how
exactly comments are intended to work with -C, --skip-comments?
> [...]
Thanks,
Erik
Re: [PATCH] Fixed incomplete and incorrect treatment of comments and trailing whitespace, Shawn Wagner, 2022/05/18
Re: [PATCH] Fixed incomplete and incorrect treatment of comments and trailing whitespace, Tim Rice, 2022/05/27
Re: [PATCH] Fixed incomplete and incorrect treatment of comments and trailing whitespace, Erik Auerswald, 2022/05/28
Re: [PATCH] Fixed incomplete and incorrect treatment of comments and trailing whitespace, Erik Auerswald, 2022/05/28