[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-datamash] Feature request: percentiles

From: Barry Nisly
Subject: Re: [Bug-datamash] Feature request: percentiles
Date: Wed, 15 Mar 2017 22:46:51 -0700

Hey Assaf,

That looks great. You did a much better job at error checking and creating more complete test scenarios.


On Wed, Mar 15, 2017 at 7:03 PM, Assaf Gordon <address@hidden> wrote:
Hello Barry,

> On Mar 15, 2017, at 01:28, Barry Nisly <address@hidden> wrote:
> Attached is a patch that implements percentiles using the parsing and processing you recommended. Check it out and let me know if you have feedback.

Fantastic work. Thank you for the extra effort to add good tests and adjust
the documentation.

I've made few minor adjustment (split lines longer than 80 characters, added few tests, updated the '--help' screen, expanded the git-commit message).

Patch attached.

If this looks good, I'll push it.

 - assaf

reply via email to

[Prev in Thread] Current Thread [Next in Thread]