Re: CVS, Cygwin and 'long long'

[Derek R. Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Incidentally, I just compiled the tip of the trunk under Cygwin.  I
had to add an include file for ULONG_MAX (I've installed the change),
but other than that, I had no problems.  I'm working on running `make
check' now.

Regards,

Derek


Derek R. Price wrote:
> Jim Hyslop wrote:
>>> Currently, the function strto_file_size in src/client.c in the
>>> trunk revision calls strtoimax.
>
> Actually, it calls strtoumax.
>
>>> This causes problems with the Windows build, trying to use a
>>> 'long long' declaration. Does anyone see any problems with
>>> reverting the call to strtoul(), as it does in the 1.11 branch?
>>>
>
> I doubt reverting this would cause immediate problems, but can we
> try to diagnose the current problem completely first?  The GNULIB
> replacement strto{i,u}max module should not be using long long if
> long long is broken (it should degrade gracefully to using long)
> and, if the replacement module is not being used, then Cygwin
> should not be defining values for uintmax_t and strtoumax() that
> don't work according to POSIX standards
>
> There is also a reasonably solid argument for using strtoumax here,
> if possible, since differing platforms may not agree on what the
> largest reasonable file size is and parsing correctly anything that
> looks like a number allows for slightly more graceful failure
> cases.
>
> Regards,
>
> Derek -- Derek R. Price CVS Solutions Architect Get CVS support at
> Ximbiot <http://ximbiot.com>! v: +1 248.835.1260 f: +1 248.835.1263
>  <mailto:derek@ximbiot.com>
>
> _______________________________________________ Bug-cvs mailing
> list Bug-cvs@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/bug-cvs
>
>
> -- Derek R. Price CVS Solutions Architect Get CVS support at
> Ximbiot <http://ximbiot.com>! v: +1 248.835.1260 f: +1 248.835.1263
>  <mailto:derek@ximbiot.com>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEhyi3LD1OTBfyMaQRAnCEAKCnq1UkGc7XchPcEZhG3yWaxPw18gCgzOG5
aV5G2RMjsG06lbnDqX2KY4g=
=vYyg
-----END PGP SIGNATURE-----