bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Feature Branch Solaris Build Broken - lib/glob.c errors


From: Derek Price
Subject: Re: Feature Branch Solaris Build Broken - lib/glob.c errors
Date: Tue, 24 May 2005 17:52:20 -0400
User-agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)

Conrad T. Pino wrote:

>Hi Derek,
>
>  
>
>>From: Derek Price
>>
>>    
>>
>>>1. #include <sys/stat.h> within glob_.h file.
>>>      
>>>
>>This would be the way to go.  You may commit this if you wish.
>>    
>>
>
>I committed an inclusion immediately before "struct stat" forward
>declaration to assure the Solaris "stat" macro is used but on 2nd
>reflection the forward declaration is moot.  I'm considering it's
>removal.  Any objection on your part?
>  
>

No objections here.  Please do so.  Also, please shorten this comment to
something like "get struct stat":

    /* Solaris may "#define stat stat64" in some cases */

Thanks,

Derek





reply via email to

[Prev in Thread] Current Thread [Next in Thread]