bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Large file issues with send_modified() in client.c


From: Brad L. Chisholm
Subject: Large file issues with send_modified() in client.c
Date: Fri, 7 Jan 2005 14:24:01 -0500
User-agent: Mutt/1.4.2.1i

One section of the send_modified() function in client.c is using int types
to contain file offsets.  This can cause overflow for very large files.
The following patch appears to correct the problem.

-Brad

Index: client.c
===================================================================
RCS file: /cvs/ccvs/src/client.c,v
retrieving revision 1.410
diff -u -r1.410 client.c
--- client.c    9 Dec 2004 19:33:50 -0000       1.410
+++ client.c    7 Jan 2005 19:27:39 -0000
@@ -4281,11 +4281,11 @@
     }
     else
     {
-       int newsize;
+       size_t newsize;
 
         {
            char *bufp = buf;
-           int len;
+           size_t len;
 
            /* FIXME: This is gross.  It assumes that we might read
               less than st_size bytes (true on NT), but not more.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]