bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: "Protocol error" fix not in v1.11.x?


From: Mark D. Baushke
Subject: Re: "Protocol error" fix not in v1.11.x?
Date: Wed, 10 Dec 2003 09:55:54 -0800

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jim.Hyslop <Jim.Hyslop@Leitch.com> writes:

> Mark D. Baushke [mailto:mdb@cvshome.org] wrote:
> > Jim.Hyslop <Jim.Hyslop@Leitch.com> writes:
> > 
> > > We've been experiencing "Protocol error: uncounted data discarded"
> > > errors. It looks like this was fixed for the 1.12 branch in
> > > server.c (CVS rev 1.289) but has not been merged into the 1.11.x
> > > branch as a bug fix (1.11 branched at 1.284). If this is the case,
> > > could this fix please be merged to the branch for the next 1.11
> > > rev?
> > 
> > If you are able to reproduce the problem, could you apply the patch to
> > your cvs 1.11.10 sources and see if it fixes the prbolem?
> Thanks for the patch, Mark.

I have committed the patch to the cvs1-11-x-branch as well.

> The problem's intermittent, so it may be difficult to verify if the patch
> works for sure. I've only seen it once since we upgraded our CVS system
> (other users have occasionally reported it). I'm assuming the log entry for
> 1.289 correctly identifies the problem that the commit is addressing :-) In
> any case, I'll run this past the other CVS admins here (I'm not the UNIX
> sysadmin, so I won't be doing the patch myself).

The problem arose when I wrote a feature to update the CVS/Template file
on all cvs update operations. Because the CVS/Template code was not the
last thing to be done in the protocol transactions, it ran into the
protocol error due to the missing call.

> By the way, other than the error message that gets spit out, does anyone
> know the effects of this error? Looking at server.c, I'm guessing that the
> file CVS/Template does not get created when checking out or updating new
> directories. Or is the problem more subtle?

Well, it means that anything in the protocol pipeline that was to be
sent after the error was found will be lost. I believe that will mean
that some data transfered from the server to the client will not be
properly decoded...

        -- Mark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)

iD8DBQE/114p3x41pRYZE/gRAlhpAKCpsr9jRBl2NgxGZTYzzJe1xgIUbwCcDtTS
id6HiMH2hak9JdTQi9xpzLM=
=rPys
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]