bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cvs-1.11.1p1 fails if CVSROOT is symbolic link


From: Derek R. Price
Subject: Re: cvs-1.11.1p1 fails if CVSROOT is symbolic link
Date: Tue, 14 Aug 2001 16:35:30 -0400

"Cameron, Steve" wrote:

> I think a lot of system administrators will use symbolic
> links as a matter of course for things like this (CVSROOT),
> because they _know_ from experience that at some point,
> _something_  will change (disk full/failed/obsolete, etc.)
> that causes them to have to move the repository (or whatever),
> and they don't want to break everything that users invariably
> build which depend on locations.  That's why things like
> symlinks and automounters were invented, of course.
> (I'm preaching to the choir, no doubt.)
>
> Might be nice if CVS could detect a symlink CVSROOT
> and complain about it (and possibly refuse to continue?)
> rather than getting an assertion failure only in some
> specific cases.
>
> Nicer still of course would be to make it tolerant of symlinked
> CVSROOTs somehow, (though, I imagine if that were possible
> it would have already been done)

Actually, I've been running cvshome.org for over a year now with symlinked
CVSROOTs without problems that I know of.  Of course there are still just
over 200 emails to address@hidden that I haven't had time to go
through yet.

I think the only thing really necessary to make this a feature is to
resolve the root to an absolute path w/o symlinks immediately after reading
it and make sure the user only specifies the "real" path to --allow-root,
or resolve those too.  There's already a function named resolve_symlink in
src/subr.c which could do most of the work.

Not that I feel it's important enough to do myself, but if someone makes a
patch, I'll check it in.

I created an issue:

    http://ccvs.cvshome.org/issues/show_bug.cgi?id=20

Derek

--
Derek Price                      CVS Solutions Architect ( http://CVSHome.org )
mailto:address@hidden         CollabNet ( http://collab.net )
--
It is as useless to argue with those who have renounced the use and authority
of reason as to administer medication to the dead.

                        - Thomas Jefferson






reply via email to

[Prev in Thread] Current Thread [Next in Thread]