bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: "cvs admin -n" aborts if tag not found


From: Derek R. Price
Subject: Re: "cvs admin -n" aborts if tag not found
Date: Thu, 15 Mar 2001 15:56:19 -0500

Anybody have any objections to me checking this in after I remove the
warning, adjust the warning one level up in admin.c to only print when in
really_quiet mode, and convert the test to work under sanity.sh?

Stephen - Please attach a ChangeLog entry next time.  Also, when returning a
pointer, please use 'NULL' and not '0';

Derek

--
Derek Price                      CVS Solutions Architect ( http://CVSHome.org )
mailto:address@hidden         CollabNet ( http://collab.net )
--
Man who live in glass house dress in basement.

Stephen Rasku wrote:

> I wrote:
>
> >I have attached a patch and a script that will reproduce the problem
> >and verify the fix.
>
> The previous patch causes a comment in the code to be invalid.  This
> new patch fixes the comment as well.  Disregard the earlier patch.
>
> --
> Stephen Rasku                   E-mail: address@hidden
> Senior Software Engineer        Web:    http://www.pop-star.net/
> TGI Technologies
>
>   ------------------------------------------------------------------------
> Index: src/rcs.c
> ===================================================================
> RCS file: /ash/cvsroot/tools/cvs/src/rcs.c,v
> retrieving revision 1.1.1.1
> diff -b -u -r1.1.1.1 rcs.c
> --- src/rcs.c   2001/02/04 20:23:40     1.1.1.1
> +++ src/rcs.c   2001/03/15 00:42:54
> @@ -2485,7 +2487,7 @@
>   * -- If tag is a branch tag, returns the branch number, not
>   *    the revision of the head of the branch.
>   * If tag or revision is not valid or does not exist in file,
> - * exit with error.
> + * return NULL.
>   */
>  char *
>  RCS_tag2rev (rcs, tag)
> @@ -2564,8 +2566,7 @@
>      if (rev)
>          return rev;
>
> -    error (1, 0, "tag `%s' does not exist", tag);
> -    /* NOT REACHED -- error (1 ... ) does not return here */
> +    error (0, 0, "tag `%s' does not exist", tag);
>      return 0;
>  }




reply via email to

[Prev in Thread] Current Thread [Next in Thread]