[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60620: [PATCH] copy.c: replace set_acl() with chmod_or_fchmod()
From: |
Ondrej Valousek |
Subject: |
bug#60620: [PATCH] copy.c: replace set_acl() with chmod_or_fchmod() |
Date: |
Tue, 24 Jan 2023 08:14:37 +0000 |
> The "at least in Linux" qualification worries me.
> Having a very quick look at the qset_acl() code suggests it clears ACLs on
> some platforms at least, which chmod_or_fchmod() does not.
> Am I reading that wrong?
You are right.
The question is - why do we need to clear ACLs?
The only real example the code in question used is via "cp --no-preserve=mode"
where I can't think of a reason why we intentionally clear ACLs
bug#60620: [PATCH] copy.c: replace set_acl() with chmod_or_fchmod(), Pádraig Brady, 2023/01/08