>From 6778871f67c6a66aacc76b0a63ff26c8b72dce87 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 22 Oct 2019 12:52:52 -0700 Subject: [PATCH 2/5] =?UTF-8?q?build:=20don=E2=80=99t=20worry=20about=20lo?= =?UTF-8?q?gical-op=20checking?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * configure.ac: Remove code tailoring --enable-gcc-warnings to GCC 4.7 and earlier, as developers no longer need to worry about GCCs that old. --- configure.ac | 6 ------ 1 file changed, 6 deletions(-) diff --git a/configure.ac b/configure.ac index 292ae0bf2..18c5a99bd 100644 --- a/configure.ac +++ b/configure.ac @@ -128,7 +128,6 @@ if test "$gl_gcc_warnings" = yes; then nw="$nw -Wunreachable-code" # Too many warnings for now nw="$nw -Wpadded" # Our structs are not padded nw="$nw -Wredundant-decls" # openat.h declares e.g., mkdirat - nw="$nw -Wlogical-op" # Too many warnings until GCC 4.8.0 nw="$nw -Wformat-nonliteral" # who.c and pinky.c strftime uses nw="$nw -Wnested-externs" # use of XARGMATCH/verify_function__ nw="$nw -Wswitch-enum" # Too many warnings for now @@ -157,11 +156,6 @@ if test "$gl_gcc_warnings" = yes; then gl_WARN_ADD([-Wno-unused-parameter]) # Too many warnings for now gl_WARN_ADD([-Wno-format-nonliteral]) - # Enable this warning only with gcc-4.8 and newer. Before that - # bounds checking as done in truncate.c was incorrectly flagged. - # See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43772 - gl_GCC_VERSION_IFELSE([4], [8], [gl_WARN_ADD([-Wlogical-op])]) - # clang is unduly picky about some things. AC_CACHE_CHECK([whether the compiler is clang], [utils_cv_clang], [AC_COMPILE_IFELSE( -- 2.21.0