bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#34817: coreutils 8.31 compile failure on rhel5


From: Bruno Haible
Subject: bug#34817: coreutils 8.31 compile failure on rhel5
Date: Wed, 13 Mar 2019 19:35:07 +0100
User-agent: KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; )

Paul Eggert wrote:
> Thanks for the bug report. I installed the attached patch into Gnulib.

A simpler fix would have been to mark the 'minus_zero' variable as 'static':


--- a/lib/strtod.c
+++ b/lib/strtod.c
@@ -302,7 +302,7 @@ compute_minus_zero (void)
 }
 # define minus_zero compute_minus_zero ()
 #else
-DOUBLE minus_zero = -0.0;
+static DOUBLE minus_zero = -0.0;
 #endif
 
 /* Convert NPTR to a DOUBLE.  If ENDPTR is not NULL, a pointer to the


When this variable was introduced, it ought to have been 'static' from the
beginning (2010-11-05); but this was harmless until 2019-01-30. I did not
notice the problem when doing the 2019-01-30 changes; sorry.

Bruno






reply via email to

[Prev in Thread] Current Thread [Next in Thread]