bug#33468: A bug with yes and --help

[Assaf Gordon]

Hello,

On 2019-02-15 1:19 p.m., Eric Blake wrote:
> On 2/15/19 12:32 PM, Assaf Gordon wrote:
> > There is at least one change in behavior, not sure if this is
> > bad enough to be a regression or doesn't really matter:
> >
> >    $ yes-OLD me -- --help | head -n1
> >    me -- --help
> >
> >    $ yes-NEW me -- --help | head -n1
> >    me --help
>
> I would argue bug-fix.
[...]
> So, I would suspect (although I have not yet tesed) that as patched, you
> would get:
>
> $ yes-NEW me -- --help | head -n1
> me --help
> $ POSIXLY_CORRECT=1 yes-NEW me -- --help | head -n1
> me -- --help
> $ yes-NEW -- me -- --help
> me -- --help

Indeed - that's how it behaves with the patch.

Thanks for explaining.

> In the gnulib patch:
> s/optional/option/

> In the coreutils patch:
> s/non-options/non-option/

Attached updates with your suggested fixes.


> Also, all coreutils callers pass reset_optind==false; does the gnulib
> interface still need to provide a reset_optind parameter, given that
> setting the parameter true forces reliance on the getopt-gnu module as
> currently coded?

The "getopt-gnu" was already a dependency before this patch,
not sure if removing this parameter will save much hassle - what do you
think ?

-assaf

gnulib-0001-long-options-add-parse_gnu_standard_options_only.patch
Description: Text Data

0001-all-detect-help-and-version-more-consistently.patch
Description: Text Data