bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#33468: A bug with yes and --help


From: Assaf Gordon
Subject: bug#33468: A bug with yes and --help
Date: Wed, 13 Feb 2019 17:56:39 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

Hello,

On 2019-02-12 7:00 p.m., Eric Blake wrote:
On 2/12/19 7:21 PM, Assaf Gordon wrote:

+  optind = 1;

Why are you doing this in every caller, instead of doing it just once
inside the body of parse_gnu_standard_options_only(), so that the state
is left unchanged at optind==1 if there were no options parsed?

That was just an ugly hack.

Here are a more complete patches (both for gnulib and for coreutils).

All existing tests pass (including nohup's exit code)
but I did not yet write new tests for these improvements.

Comments welcomed.
 -assaf





Attachment: 0001-all-detect-help-and-version-more-consistently-FIXME.patch.gz
Description: application/gzip

Attachment: gnulib-0001-long-options-add-parse_gnu_standard_options_only.patch.gz
Description: application/gzip


reply via email to

[Prev in Thread] Current Thread [Next in Thread]