bug#23283: 'tail -f' reports "unrecognized file system" for Plexistor's M1FS

[Bernhard Voelker]

On 04/13/2016 10:22 PM, Yigal Korman wrote:
> Hi,
> We (Plexistor Ltd.) are offering the first file-system to support
> persistent memory.
> You can download the community edition from our website:
> http://www.plexistor.com/download/
> Our customers are reporting the issue mentioned in the title for our FS,
> this is a common output:
> 
>> $ tail -f file
>> tail: unrecognized file system type 0x5346314d for ‘file’. please report
> this to address@hidden reverting to polling
> 
> Our FS is local and supports inotify.
> If it's all possible, please add us to the list of known FSs.
> See proposed (trivial) patch below.
> 
> Thank you,
> Yigal
> 
> From 9d4a87fa71e7c854adec41c5ad9eebd2ad51d5b6 Mon Sep 17 00:00:00 2001
> From: Yigal Korman <address@hidden>
> Date: Wed, 13 Apr 2016 16:15:20 +0300
> Subject: [PATCH] stat,tail: Add support for M1FS filesystem
> 
> * src/stat.c (human_fstype): Add M1FS ID definition.
> ---
> src/stat.c | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/src/stat.c b/src/stat.c
> index 4d7ead3..a71d6af 100644
> --- a/src/stat.c
> +++ b/src/stat.c
> @@ -364,6 +364,8 @@ human_fstype (STRUCT_STATVFS const *statfsbuf)
> return "logfs";
> case S_MAGIC_LUSTRE: /* 0x0BD00BD0 remote */
> return "lustre";
> + case S_MAGIC_M1FS: /* 0x5346314d local */
> + return "m1fs";
> case S_MAGIC_MINIX: /* 0x137F local */
> return "minix";
> case S_MAGIC_MINIX_30: /* 0x138F local */
> --
> 1.9.3

Thanks for the report and the patch.
Somehow, the indentation in the email got lost.
I also added a NEWS entry, tweaked the commit message a bit to adhere
to our standards and made the ID definition upper-case to avoid the
following "make syntax-check" failure:

  $ make syntax-check
  ...
  0x5346314d
  maint.mk: Constants in src/stat.c should be 4 or 8 upper-case chars
  cfg.mk:737: recipe for target 'sc_fs-magic-compare' failed
  make: *** [sc_fs-magic-compare] Error 1

Pushed the attached at:
http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=8faf269250

I'm hereby marking this bug as done.

Have a nice day,
Berny

0001-stat-tail-add-support-for-M1FS.patch
Description: Text Data